Linus Torvalds labels Google engineer's RISC-V code as 'garbage' in a Linux 6.17 dispute

: Linus Torvalds, the founder of the Linux kernel, firmly dismissed a code patch from a Google engineer that aimed to improve RISC-V support in Linux 6.17, calling it 'garbage' due to insufficient merit and poor timing. The patch, containing a controversial helper function make_u32_from_two_u16(), was submitted late during the merge window, despite prior warnings about submission deadlines due to Torvalds' travel schedule. Torvalds emphasized the patch's negative impact on data ordering and core kernel maintainability, warning against generic code pollution. The incident prompted mixed reactions, with some defending Torvalds' strict standards while others questioned his tone, urging for constructive criticism instead.

Linus Torvalds, known for his uncompromising standards, made headlines by rejecting a code contribution from a Google engineer aimed at improving RISC-V architecture support in the upcoming Linux 6.17 release. The submission was criticized mainly for its timing and technical inadequacies, sparking debate within the developer community. The rejection took place during the Linux Kernel Mailing List discussions, underscoring Torvalds' emphasis on quality and timely submissions.

The submission included a helper function named make_u32_from_two_u16(), which Torvalds argued introduced unnecessary complexity and obscured data ordering in the codebase. He stated that it made 'the world actively a worse place to live,' highlighting the potential for errors and maintenance challenges it introduced into generic header files—a significant issue he wanted to avoid for the Linux kernel's maintainability.

Torvalds stressed that contributions should focus on architecture-specific changes unless generic updates could clearly justify their inclusion and provide substantial benefits. His critique was not solely technical; he issued a broader warning against late submissions, suggesting contributors adhere strictly to deadlines to prevent project delays. The Google engineer acknowledged the feedback and promised to revise the submission for an earlier future version.

In response to the incident, the developer community provided mixed feedback regarding Torvalds' approach. Some supported his tough leadership style as essential for maintaining the high standards required by such a widely-used open-source project. Others argued that his method of publicly chastising contributors might be counterproductive, suggesting that more positive feedback could encourage better improvements and collaboration.

Related online discussions reflect a broader examination of Torvalds' leadership style within the open-source community. While his directness is seen as crucial by some, it raises questions about community building and the impact of communication style on encouraging contributions. As Torvalds continues to steer Linux development, the balance between maintaining high standards and being supportive of contributors remains a topic of interest.

Sources: TechSpot, Tom's Hardware